forked from CoplayDev/unity-mcp
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/session based instance routing #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cf80937
Add support for multiple Unity instances
sakurachan d647d99
fix port detection
sakurachan b75202a
add missing unity_instance parameter
sakurachan 83b96ac
add instance params for resources
sakurachan 73f8206
Fix CodeRabbit review feedback
sakurachan 13b8fb2
Fix CodeRabbit feedback: reconnection fallback and annotations safety
sakurachan 0a8591f
Fix instance sorting and logging issues
sakurachan aa01fe6
update uv.lock to prepare for merging into main
sakurachan e6f9c4f
Restore Python 3.10 lockfiles and package list_unity_instances tool
dsarno 5e3a035
Deduplicate Unity instance discovery by port
dsarno 97048ae
Merge remote-tracking branch 'upstream/main' into fix/multi-instance
dsarno 198a4ff
Scope status-file reload checks to the active instance
dsarno bba056a
refactor: implement FastMCP middleware for session-based instance rou…
dsarno b8004a1
fix: convert resource templates to static resources for discoverability
dsarno 3f7deeb
feat: improve material properties and sync Server resources
dsarno 1e43fb5
fix: repair instance routing and simplify get_unity_instance_from_con…
dsarno 0633261
refactor: standardize instance extraction and remove dead imports
dsarno 50c67b1
fix: critical timezone and import bugs from code review
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify safety check logic when port becomes available.
The safety check at lines 370-374 throws an error if
GetPortWithFallback()returns the same port asoldPort. However,GetPortWithFallback()internally callsWaitForPortRelease(), which might successfully reclaim the stored port if it becomes available during the wait. In that scenario, returning the same port is valid and should be used, not treated as an error.Consider revising the logic to distinguish between:
🤖 Prompt for AI Agents