Skip to content

fix: accname related role edge cases#54

Merged
drwpow merged 1 commit intodrwpow:mainfrom
jlp-craigmorten:fix-accname-edgecases
Apr 18, 2025
Merged

fix: accname related role edge cases#54
drwpow merged 1 commit intodrwpow:mainfrom
jlp-craigmorten:fix-accname-edgecases

Conversation

@jlp-craigmorten
Copy link
Contributor

@jlp-craigmorten jlp-craigmorten commented Apr 18, 2025

Changes

Relates to #25

How to Review

This change was prompted by the following failing test cases taken from the WPT roles-contextual.html suite:

  • el-aside-in-section-aria-label-whitespace
  • el-aside-in-section-aria-labelledby-empty
  • el-aside-in-section-aria-labelledby-whitespace
  • el-aside-in-section-title
  • el-img-empty-alt-aria-label-whitespace
  • el-img-empty-alt-aria-labelledby-empty
  • el-img-empty-alt-aria-labelledby-whitespace
  • el-img-no-name
  • el-section-aria-label-whitespace
  • el-section-aria-labelledby-non-existing
  • el-section-aria-labelledby-empty
  • el-section-aria-labelledby-whitespace
  • el-section-title

This change does not cover the following known failures:

  • el-aside-in-section-aria-labelledby-non-existing
  • el-img-empty-alt-aria-labelledby-non-existing
  • el-th-in-row (from the WPT table-roles.html suite)

These would require a more accurate ACCNAME algorithm implementation for the first two, and supporting an involved algorithm to scan all rows in a table to support rowheader when scope is auto.

Checklist

  • Unit tests updated

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: 297c359

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
html-aria Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@drwpow drwpow merged commit 74659ab into drwpow:main Apr 18, 2025
6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants