Skip to content

Fix issue with downgraded PHP #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driftingly merged 1 commit into from
Feb 27, 2023
Merged

Fix issue with downgraded PHP #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/downgraded_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
- uses: "ramsey/composer-install@v2"

# downgrade /src to PHP 7.2
- run: vendor/bin/rector process src --config build/rector-downgrade-php-72.php --ansi
- run: vendor/bin/ecs check src --fix --ansi
- run: vendor/bin/rector process src config --config build/rector-downgrade-php-72.php --ansi
- run: vendor/bin/ecs check src config --fix --ansi

# copy PHP 7.2 composer
- run: cp build/composer-php-72.json composer.json
Expand Down
5 changes: 3 additions & 2 deletions src/Rector/StaticCall/RequestStaticValidateToInjectRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ private function shouldSkip(StaticCall|FuncCall $node): bool
$classMethod = $this->betterNodeFinder->findParentType($node, ClassMethod::class);
if ($classMethod instanceof ClassMethod) {
$classMethodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
if ($classMethodReflection?->getPrototype()?->getDeclaringClass()?->getName() !== $class->namespacedName?->toString()
) {
$classMethodNamespaceName = $classMethodReflection?->getPrototype()?->getDeclaringClass()?->getName();
$classNamespaceName = $class->namespacedName?->toString();
if ($classMethodNamespaceName !== $classNamespaceName) {
return true;
}
}
Expand Down