Don't run Rector on forks #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Rector on forks gives this the error message below:
Futhermore the contributer gets an (email) notification about a failed PR check:
[driftingly/rector-laravel] PR run failed at startup: Rector - Fix `check-active-classes` and re-enable code_analysis workflow (dd5284a). This is very anoying. Other Rector extensions just exclude Rector for forks, thats why I just grabbed the one from rector-doctrine. All rector-* packages now removed rector.yaml in fafor of the Rector job code_analisis.yaml, so I made that change here also.