Fix check-active-classes and re-enable code_analysis workflow
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@driftingly This one is ready for review 🥳 |
Owner
|
This is great! Thanks, @rene-bos appreciate it. |
Contributor
Author
|
You are welcome, @driftingly! I love to have good CI 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I find the code_analysis very important I researched the problem and found it. The problem lies in this commit in the reusable-workflows repository. The fetching of a default easy-ci.php is removed. Thats why I grabbed the one from rector-doctrine. Did not have to change anything to our needings at all.