Support updating an existing return type with generics #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only supported if the existing PHPDoc return type is the same as the native return type. This way we ensure that we don't change types.
Contributor
Author
|
Forgot to run PHPStan local before the last commit, will fix tomorrow. |
Contributor
Author
|
@driftingly This rule is ready to get reviewed (and hopefully to get merged!). I'm working on a further improvement of this rule which is build on top of this PR. I will prepare the PR if this one merged. That PR will fix the generics for BelongsTo and MorphTo, which both need a TChildModel specified. |
Owner
|
Thanks @rene-bos! |
rene-bos
deleted the
support-updating-existing-return-docblock-with-generics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only supported if the existing PHPDoc return type is the same as the native return type. This way we ensure that we don't change types.
Not updating of another type was already covered with a test. I added a test for the case when we can update the PHPDoc with only the generics.