Filter out internal PHP functions from set #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftingly
force-pushed
the
adc/set-use-native
branch
from
bf5349f to
ca8922d
Compare
driftingly
force-pushed
the
adc/set-use-native
branch
from
409f7ba to
51a289d
Compare
driftingly
added a commit
that referenced
this pull request
Jun 7, 2023
* Filter out internal PHP functions
Contributor
|
Hi @driftingly, could we make filtering out internal PHP functions optional? There are often differences between the helpers and related PHP functions. For example, the inspiration for this PR (str_contains) doesn't accept an array of strings. We'd like to standardize the use of static helpers when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters out internal PHP functions from the
laravel-array-str-functions-to-static-callset.Closes #107