Skip to content

Conversation

@briangreunke
Copy link
Contributor

@briangreunke briangreunke commented Nov 19, 2025

Summary

This change updates the get_user_data_credentials API call and its usage to explicitly scope the credentials fetch by the current organization and workspace. This ensures that user data credentials are retrieved with the necessary context, improving security and logical separation.

Conventional Commit Breakdown

  • Type: feat
  • Subject: Scope credentials fetch by organization and workspace

Key Changes

  • dreadnode/api/client.py:
    • The get_user_data_credentials method now accepts organization_id and workspace_id as parameters.
    • These parameters are included as query parameters (org_id and workspace_id) in the GET request to /user-data/credentials.
  • dreadnode/main.py:
    • The credential_fetcher lambda, used during the initialization of _credential_manager, has been updated.
    • It now passes self._organization.id and self._workspace.id to the api.get_user_data_credentials call.

Results

When artifacts are uploaded to s3, the prefix will be better scoped to organizations and workspaces, versus users.

Testing/Verification

Tested locally by running unit tests and verifying the API call structure.

Generated Summary:

  • Updated get_user_data_credentials method in ApiClient to accept organization_id and workspace_id as parameters.
  • Modified the API request to include parameters for enhanced credentials retrieval based on specific organizational and workspace contexts.
  • Adjusted the call to get_user_data_credentials in Dreadnode to pass the necessary IDs, ensuring proper functionality with the new method signature.
  • These changes may improve granularity in user data access, allowing for more tailored API responses based on organization and workspace.

This summary was generated with ❤️ by rigging

@briangreunke briangreunke marked this pull request as ready for review November 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants