feat(user-data): Scope credentials fetch by organization and workspace #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change updates the
get_user_data_credentialsAPI call and its usage to explicitly scope the credentials fetch by the current organization and workspace. This ensures that user data credentials are retrieved with the necessary context, improving security and logical separation.Conventional Commit Breakdown
featScope credentials fetch by organization and workspaceKey Changes
dreadnode/api/client.py:get_user_data_credentialsmethod now acceptsorganization_idandworkspace_idas parameters.org_idandworkspace_id) in the GET request to/user-data/credentials.dreadnode/main.py:credential_fetcherlambda, used during the initialization of_credential_manager, has been updated.self._organization.idandself._workspace.idto theapi.get_user_data_credentialscall.Results
When artifacts are uploaded to s3, the prefix will be better scoped to organizations and workspaces, versus users.
Testing/Verification
Tested locally by running unit tests and verifying the API call structure.
Generated Summary:
get_user_data_credentialsmethod inApiClientto acceptorganization_idandworkspace_idas parameters.get_user_data_credentialsinDreadnodeto pass the necessary IDs, ensuring proper functionality with the new method signature.This summary was generated with ❤️ by rigging