Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@starnop
Copy link
Contributor

@starnop starnop commented Jun 20, 2019

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes part of #596

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@starnop starnop force-pushed the doc-0.4.0 branch 3 times, most recently from 29d43cc to 0322ba8 Compare June 20, 2019 12:21
@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #623 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   46.13%   46.13%           
=======================================
  Files          99       99           
  Lines        5893     5893           
=======================================
  Hits         2719     2719           
  Misses       2949     2949           
  Partials      225      225

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af92c43...d17e7d6. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit d21ddfe into dragonflyoss:master Jun 20, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
doc: update doc because update 0.3 to 0.4
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
doc: update doc because update 0.3 to 0.4
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants