Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@starnop
Copy link
Contributor

@starnop starnop commented Jun 20, 2019

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/M labels Jun 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #621 into master will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   46.28%   46.16%   -0.13%     
==========================================
  Files          99       99              
  Lines        5876     5892      +16     
==========================================
  Hits         2720     2720              
- Misses       2932     2948      +16     
  Partials      224      224
Impacted Files Coverage Δ
supernode/daemon/mgr/progress/progress_util.go 21.09% <ø> (ø) ⬆️
supernode/daemon/mgr/progress/progress_manager.go 23.84% <0%> (-2.25%) ⬇️
supernode/daemon/mgr/scheduler/manager.go 25.38% <0%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7431049...eca0cc0. Read the comment docs.

Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit a5e769d into dragonflyoss:master Jun 20, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
bugfix: update the client progress after success to schedule
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
bugfix: update the client progress after success to schedule
sungjunyoung pushed a commit to sungjunyoung/Dragonfly that referenced this pull request May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug This is bug report for project size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants