This repository was archived by the owner on Dec 20, 2024. It is now read-only.
bugfix: increase load of the peer serving for others #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
- Coverage 46.28% 46.26% -0.03%
==========================================
Files 99 99
Lines 5876 5877 +1
==========================================
- Hits 2720 2719 -1
- Misses 2932 2933 +1
- Partials 224 225 +1
Continue to review full report at Codecov.
|
starnop
reviewed
Jun 20, 2019
|
|
||
| // if service has failed for EliminationLimit times, and then it should not be needed. | ||
| if peerState.ServiceErrorCount >= config.EliminationLimit { | ||
| if peerState.ServiceDownTime != nil && peerState.ServiceErrorCount.Get() >= config.EliminationLimit { |
Contributor
There was a problem hiding this comment.
s/ServiceDownTime/ServiceErrorCount?
Contributor
|
LGTM. |
Signed-off-by: lowzj <[email protected]>
starnop
added a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
bugfix: increase load of the peer serving for others
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
bugfix: increase load of the peer serving for others
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
…ss#620) Signed-off-by: santong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lowzj [email protected]
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews