Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Conversation

@starnop
Copy link
Contributor

@starnop starnop commented Jun 18, 2019

Signed-off-by: Starnop [email protected]

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot pouchrobot added kind/bug This is bug report for project size/M labels Jun 18, 2019
@starnop starnop force-pushed the last-modified-parse branch from a4dcedc to b8df5c9 Compare June 18, 2019 12:38
@codecov-io
Copy link

codecov-io commented Jun 18, 2019

Codecov Report

Merging #617 into master will increase coverage by 0.03%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   46.13%   46.17%   +0.03%     
==========================================
  Files          99       99              
  Lines        5850     5858       +8     
==========================================
+ Hits         2699     2705       +6     
  Misses       2928     2928              
- Partials      223      225       +2
Impacted Files Coverage Δ
common/util/http_util.go 57.28% <0%> (-0.28%) ⬇️
supernode/daemon/mgr/cdn/cache_detector.go 6.55% <0%> (+0.2%) ⬆️
supernode/daemon/mgr/cdn/manager.go 19.31% <0%> (ø) ⬆️
common/util/net_util.go 56.39% <77.77%> (+1.55%) ⬆️
supernode/daemon/mgr/scheduler/manager.go 25.19% <0%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc5cc1d...6e3d4eb. Read the comment docs.

@starnop starnop force-pushed the last-modified-parse branch from b8df5c9 to 6e3d4eb Compare June 18, 2019 13:08
Copy link
Member

@lowzj lowzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowzj lowzj merged commit f0b75ba into dragonflyoss:master Jun 19, 2019
starnop pushed a commit to starnop/Dragonfly that referenced this pull request Nov 27, 2019
bugfix: parse the lastmodified header to timestamp
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
bugfix: parse the lastmodified header to timestamp
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug This is bug report for project size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants