This repository was archived by the owner on Dec 20, 2024. It is now read-only.
feature: store piece md5s with native bytes #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 46.07% 46.14% +0.06%
==========================================
Files 99 99
Lines 5853 5843 -10
==========================================
- Hits 2697 2696 -1
+ Misses 2930 2924 -6
+ Partials 226 223 -3
Continue to review full report at Codecov.
|
lowzj
reviewed
Jun 18, 2019
| pieceMD5s = strings.Split(string(bytes), "\n") | ||
|
|
||
| for _, v := range pieceMD5s { | ||
| logrus.Infof("success to read piece md5 file: %s", v) |
Member
There was a problem hiding this comment.
It's better to log this one line with taskId on debug level.
Contributor
Author
There was a problem hiding this comment.
In fact, they are some code for test. So sorry for that. I have deleted them. 😢
Signed-off-by: Starnop <[email protected]>
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
feature: store piece md5s with native bytes
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
feature: store piece md5s with native bytes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
We store the piece md5s with json.Marsal(slice), and we will get piece md5 files like this
It's unfriendly to read and most importantly, it's not compatible with the Java version which looks like this
So I update the way to store the piece md5s.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews