Skip to content

force update #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benle7 merged 1 commit into from
Aug 20, 2025
Merged

force update #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions platform/mellanox/mlnx-platform-api/sonic_platform/bmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ def update_components_firmware(self, fw_image, fw_ids=None, force_update=False,
logger.log_notice(f'Firmware update result: {ret}')

# Downgrade detected
if ret == RedfishClient.ERR_CODE_LOWER_VERSION:
if force_update == False and ret == RedfishClient.ERR_CODE_LOWER_VERSION:
logger.log_notice(f'Firmware image timestamp is lower than the current timestamp')

if msg:
Expand All @@ -423,7 +423,11 @@ def update_components_firmware(self, fw_image, fw_ids=None, force_update=False,
return (ret, msg)

def update_firmware(self, fw_image):
return self.update_components_firmware(fw_image)
ret, msg = self.update_components_firmware(fw_image)
if ret == RedfishClient.ERR_CODE_LOWER_VERSION:
logger.log_notice(f'Try to update BMC firmware with force update for downgrading')
ret, msg = self.update_components_firmware(fw_image, force_update=True)
return (ret, msg)

@with_credential_restore
def trigger_bmc_debug_log_dump(self):
Expand Down Expand Up @@ -461,7 +465,7 @@ def get_version(self):
ret = 0
version = 'N/A'
try:
fw_id = self.get_component_attr('BMC', 'id')
fw_id = self.get_id()
if not fw_id:
logger.log_error('BMC firmware ID is not defined')
return 'N/A'
Expand Down