Skip to content

Add comments #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benle7 merged 1 commit into from
Jul 28, 2025
Merged

Add comments #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion platform/mellanox/mlnx-platform-api/sonic_platform/bmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def wrapper(self, *args, **kwargs):
logger.log_notice(f'BMC TPM based password recovered. Retry {api_func.__name__}()')
ret, data = api_func(self, *args, **kwargs)
else:
# TODO(BMC): Check if logout (parallel cases \ common session)
# TODO(BMC): Check if logout works (parallel cases \ common session)
self.logout()
logger.log_notice(f'Fail to recover BMC based password')
return (RedfishClient.ERR_CODE_AUTH_FAILURE, data)
Expand Down
6 changes: 5 additions & 1 deletion platform/mellanox/mlnx-platform-api/sonic_platform/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ def install_firmware(self, image_path, allow_reboot=True, force_update=False, pr
raise

if (ret == 0):
# TODO(BMC): Add power cycle for apply the update
# TODO(BMC): Check if power cycle is required for apply the installation
return (True, (error_msg, updated))
else:
print(f'Fail to upgrade {self.get_firmware_id()} firmware ({error_msg})')
Expand Down Expand Up @@ -1039,6 +1039,10 @@ def get_serial_number(self):
return None
else:
return eeprom_info.get('SerialNumber')

# TODO(BMC): Check if needed for indicate a power cycle requirement
def get_firmware_update_notification(self, image_path):
return "A power cycle is required to complete {} firmware update".format(self.name)

class ComponentBMC(ComponentBMCObj):
COMPONENT_NAME = 'BMC'
Expand Down