Migrate from Unittest to pytest
#1620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
migrate-from-unittest-to-pytest
branch
3 times, most recently
from
d1acb54 to
f99eea9
Compare
jeffwidman
force-pushed
the
migrate-from-unittest-to-pytest
branch
2 times, most recently
from
d6299ed to
8fbbbb3
Compare
I only migrated tests that will continue to be used even after the removal of the old `Simple*` classes in #1196. The `decorator` in tox is leftover from a previous usage that was already removed from the code but not from tox.
These fixtures and helper functions were either unused or easily replaced.
jeffwidman
force-pushed
the
migrate-from-unittest-to-pytest
branch
2 times, most recently
from
f918ec7 to
5e58437
Compare
jeffwidman
force-pushed
the
migrate-from-unittest-to-pytest
branch
from
5e58437 to
9eb63e1
Compare
Owner
|
radness! |
Contributor
Author
|
Thanks. I hadn't merged because I was planning to migrate a couple more fixtures just finished just yet, but I guess I didn't mention that anywhere. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates tests from
unittesttopytest.I only migrated tests that will continue to be used even after the
removal of the old
Simple*classes in #1196.The motivation for this work was threefold:
pytestis generally more readableunittestThis change is