feat(validator-debt): abort calculation if fees are zero (#3244)#286
Merged
bgm-malbeclabs merged 1 commit intomainfrom Mar 11, 2026
Merged
feat(validator-debt): abort calculation if fees are zero (#3244)#286bgm-malbeclabs merged 1 commit intomainfrom
bgm-malbeclabs merged 1 commit intomainfrom
Conversation
bgm-malbeclabs
force-pushed
the
bgm/abort_if_zero
branch
from
3b0a8f4 to
c68689b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds an early-exit guard in the validator debt calculation workflow: if the fee parameters are zero, the distribution calculation is aborted instead of proceeding with a zero-fee computation.
Changes:
- Added a check in
calculate_distributionto bail out whenbase_block_rewards_pctis zero - Added a CHANGELOG entry for the new behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/validator-debt/src/worker/mod.rs |
Adds early bail if base_block_rewards_pct is zero before debt calculation |
crates/validator-debt/CHANGELOG.md |
Documents the new feature (PR link placeholder not filled in) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
bgm-malbeclabs
force-pushed
the
bgm/abort_if_zero
branch
from
c68689b to
a50986b
Compare
karl-dz
previously approved these changes
Mar 11, 2026
bgm-malbeclabs
force-pushed
the
bgm/abort_if_zero
branch
from
f10d3ab to
28a4086
Compare
bgm-malbeclabs
force-pushed
the
bgm/abort_if_zero
branch
from
28a4086 to
6dbaf75
Compare
karl-dz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR short circuits the debt calculation if fees are set to zero.
Closes malbeclabs/doublezero#3244
Testing Verification