Edit create_states_mapping function from disk cache to memory cache.#1033
Open
XDeviation wants to merge 1 commit intodottxt-ai:mainfrom
Open
Edit create_states_mapping function from disk cache to memory cache.#1033XDeviation wants to merge 1 commit intodottxt-ai:mainfrom
XDeviation wants to merge 1 commit intodottxt-ai:mainfrom
Conversation
Contributor
|
Hi @XDeviation! I'm sorry your PR had never been discussed before. We recently released Outlines v1 that changes a lot in the library. There's still a function |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when using the fixed output format of response_format in vLLM, the same regex_string and tokenizer are repeatedly used to create the
CFGGuideandRegexGuideclasses and call theirget_next_instructionmethods. During the creation,create_states_mappinguses thecachedecorator to read the cache from the disk. However, the time spent reading the cache from the disk accounts for most of the total time required forget_next_instruction. I believe we can speed up this process by changing the cache ofcreate_states_mappingto be stored in memory.Here's some logs