Skip to content

Conversation

@vijayrkn
Copy link
Contributor

No description provided.

@vijayrkn vijayrkn requested a review from mmitche September 30, 2021 18:30
@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

@MichaelSimons Can you ensure that the right source-build commits have made it into this?

@MichaelSimons
Copy link
Member

I'm not seeing the source-build ArPow commit - 4511f52#diff-6a28d92de8923be8821f2123541dc23c8ad0359c96117709e6d49e752c0303d2.

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

@vijayrkn We may want to port commits from main (except the 5.0 versioning update) back into 3.1. Maybe main should generally be archived if we aren't shipping a 5.0/6.0 version anyway.

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

Hmmm. @MichaelSimons I assume that also requires updating to a 6.0 arcade?

Maybe an even better approach is to ship a 6.0 version of Xdt for this? We would need to get NuGet to update their referenced version though, since I think they're on 3.0.0

@vijayrkn
Copy link
Contributor Author

Does main have all the required changes? Then we can use the build from Main and brand 6.0

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

Does main have all the required changes? Then we can use the build from Main and brand 6.0

It should. It's really only that commit that @MichaelSimons referenced, but that commit may depend on other arcade updates.

@MichaelSimons
Copy link
Member

Yes, we would need 6.0 arcade. Main has all of the source-build changes we need.

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

My preferred method is to ship a 3.1.1 if possible, on that cherry-picked commit.

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

Yes, we would need 6.0 arcade. Main has all of the source-build changes we need.

Sounds good. Can you work with the NuGet folks to get their major version updated?

@MichaelSimons
Copy link
Member

Can you work with the NuGet folks to get their major version updated?

@mmitche - can you clarify who you are asking to work with the NuGet folks? I'm unclear what the ask is about.

@mmitche
Copy link
Member

mmitche commented Sep 30, 2021

Can you work with the NuGet folks to get their major version updated?

@mmitche - can you clarify who you are asking to work with the NuGet folks? I'm unclear what the ask is about.

  • the SDK references 3.1.0, and we'll be updating that to a 6.0.0 version that will be shipped on NuGet.
  • NuGet itself references 3.0.0. This might be okay, but when we update to 6.0.0 in the SDK, the major versions begin to differ, which doesn't sound like a good idea. Ideally both components would reference 6.0.0 going forward.

@MichaelSimons
Copy link
Member

NuGet itself references 3.0.0. This might be okay, but when we update to 6.0.0 in the SDK, the major versions begin to differ, which doesn't sound like a good idea. Ideally both components would reference 6.0.0 going forward.

That makes sense. Yes I can reach out to them and ask them to upgrade.

@MichaelSimons
Copy link
Member

Has any traction been made on release 3.1.1? Once that happens I can reach out to NuGet as well as update the SDK reference.

@vijayrkn
Copy link
Contributor Author

Is there an action item on me? I have created a new branch but I don't have any idea on what changes are needed.

@MichaelSimons
Copy link
Member

Is there an action item on me? I have created a new branch but I don't have any idea on what changes are needed.

This is the primary change we need released - #352. Aa Matt mentioned, this is going to need an updated arcade version as well. I don't have any bandwidth to help.

@mmitche mmitche closed this Mar 21, 2023
@ViktorHofer ViktorHofer deleted the dev/vramak/Update31servicingVersion branch November 14, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants