Empty string check optimization #3826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Sep 2, 2020
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/FormatControl.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3826 +/- ##
====================================================
- Coverage 67.51338% 36.33545% -31.17793%
====================================================
Files 1394 917 -477
Lines 505722 250612 -255110
Branches 41070 36783 -4287
====================================================
- Hits 341430 91061 -250369
+ Misses 158371 154356 -4015
+ Partials 5921 5195 -726
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
suggested changes
Sep 4, 2020
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/FormatControl.cs
Outdated
Show resolved
Hide resolved
ghost
added
waiting-author-feedback
RussKie
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
RussKie
approved these changes
Sep 9, 2020
Contributor
|
Thank you |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1820?view=vs-2019
Microsoft Reviewers: Open in CodeFlow