Skip to content

Remove netcoreapp2.1 artifacts and support #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelSimons merged 4 commits into from
May 22, 2023
Merged

Remove netcoreapp2.1 artifacts and support #674

MichaelSimons merged 4 commits into from
May 22, 2023

Conversation

@MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented May 16, 2023

@MichaelSimons
Copy link
Member Author

MichaelSimons commented May 16, 2023

cc @ViktorHofer - FYI

@MichaelSimons MichaelSimons mentioned this pull request May 16, 2023
Closed
@MichaelSimons
Copy link
Member Author

MichaelSimons commented May 16, 2023

This requires dotnet/runtime#84782 to be merged first.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 16, 2023

Isn't dotnet/runtime#84782 blocked on dotnet/runtime#86151?

@MichaelSimons
Copy link
Member Author

MichaelSimons commented May 16, 2023

Isn't dotnet/runtime#84782 blocked on dotnet/runtime#86151?

I don't think so. Because the tip of runtime doesn't have prebuilt detection enabled, there is no dependency. In the full product build, the SBRP version from installer is what gets used.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 19, 2023

Sorry but I still don't understand what I need to do in the PR to make it ready to be merged. Do I just need to add the SBRP package feed?

@MichaelSimons
Copy link
Member Author

MichaelSimons commented May 19, 2023

Sorry but I still don't understand what I need to do in the PR to make it ready to be merged. Do I just need to add the SBRP package feed?

Let's discuss in the PR instead of here.

@ViktorHofer
Copy link
Member

ViktorHofer commented May 19, 2023

Just merged the runtime PR in. This should now be unblocked.

@MichaelSimons MichaelSimons merged commit 3980a87 into dotnet:main May 22, 2023
@MichaelSimons MichaelSimons deleted the cleanup-netcoreapp2.1 branch May 22, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mthalman mthalman mthalman approved these changes

@oleksandr-didyk oleksandr-didyk Awaiting requested review from oleksandr-didyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove netcoreapp2.1 artifacts and support from SBRP

3 participants

@MichaelSimons @ViktorHofer @mthalman