Repository navigation
Honor content type overrides - #1016
Merged
dtivel merged 5 commits intoAug 18, 2026
Merged
Conversation
kennethr127
force-pushed
the
kennethr127/honor-content-type-overrides
branch
from
May 6, 2026 21:56
db8f4bc to
6cd7611
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dtivel
requested changes
Aug 8, 2026
dtivel
left a comment
Collaborator
There was a problem hiding this comment.
@kennethr127, thank you for contributing this fix!
I’m requesting a few focused changes before merging:
- Avoid stripping trailing slashes when matching override part names, since that can make malformed names match valid parts.
- Make the
OverrideandDefaultmodes explicit when selecting content types. - Simplify the test to open the source VSIX once in read-only mode.
- Use separate
NotNullandEqualassertions for clearer failures.
With those changes, this should be ready to merge.
Contributor
Author
|
@dtivel Thank you reviewing this change and leaving feedback! I just pushed an update that should address all your feedback. Please let me know if I missed anything. |
dtivel
reviewed
Aug 15, 2026
dtivel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the updates, @kennethr127!
Collaborator
|
@kennethr127, thanks for the changes. Can you rebase on latest |
…n the package are not honored.
…pes calls to make the intended precedence explicit. Removed unneeded ShadowCopyPackage calls in unit test, made Asserts less ambiguous, added and some additional asserts. Added a new test to validate that content types are not changes if the Override is invalid.
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
kennethr127
force-pushed
the
kennethr127/honor-content-type-overrides
branch
from
August 18, 2026 17:27
6657428 to
2894d4c
Compare
dtivel
approved these changes
Aug 18, 2026
dtivel
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks, @kennethr127!
This was referenced Sep 2, 2026
Closed
This was referenced Sep 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Overrides in the [Content_Types].xml file in the package are not being honored during signing. This update addresses that issue by checking for any overrides when retrieving the ContentType.
Fixes #1015