Repository navigation
Reconcile outstanding MTP vendoring updates - #56802
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Evangelink
requested review from
a team,
lbussell and
mthalman
as code owners
October 27, 2026 13:01
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the reporting and vendoring updates.
No open issues 🎉
What changed in this PR
Reconciles four Microsoft.Testing.Platform vendoring reports in the SDK’s dotnet test implementation, adapting upstream reporting changes while preserving aggregate exit-code semantics and existing protocol support.
Changes:
- Adds neutral “No affected tests selected” output for successful affected-run orchestrators that never start a test host, and “Zero tests ran” summaries for successful empty runs.
- Expands unit and integration coverage for no-selection, cancellation, session failures, and ignored exit-code policies.
- Updates vendoring baselines, reporting guidance, and 13 localization files; clarifies GitHub Actions message forwarding in comments only.
| File | Description |
|---|---|
| test/dotnet.Tests/CommandTests/Test/TestApplicationHandlerTests.cs | Covers no-selection output, cancellation, and aggregate failures. |
| test/dotnet.Tests/CommandTests/Test/TerminalTestReporterTests.cs | Verifies neutral statuses, summary colors, and session failures. |
| test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs | Adds orchestrator and session-failure integration coverage. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hant.xlf | Adds Traditional Chinese localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hans.xlf | Adds Simplified Chinese localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.tr.xlf | Adds Turkish localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ru.xlf | Adds Russian localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.pt-BR.xlf | Adds Brazilian Portuguese localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.pl.xlf | Adds Polish localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ko.xlf | Adds Korean localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ja.xlf | Adds Japanese localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf | Adds Italian localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf | Adds French localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf | Adds Spanish localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf | Adds German localization entry awaiting translation. |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf | Adds Czech localization entry awaiting translation. |
| src/Cli/dotnet/Commands/Test/MTP/TestApplicationHandler.cs | Connects successful affected-run completion to no-selection reporting. |
| src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporterOptions.cs | Clarifies the existing AllowZeroTests contract. |
| src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporter.cs | Implements neutral no-selection and successful zero-test output. |
| src/Cli/dotnet/Commands/Test/CliConstants.cs | Clarifies GitHub Actions forwarding comments without protocol changes. |
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Defines the no-selection message and translator guidance. |
| src/Cli/AGENTS.md | Documents neutral reporting and aggregate exit-code authority. |
| eng/vendored-files.json | Updates four upstream baselines and SDK adaptation notes. |
Review effort: Balanced
Evangelink
enabled auto-merge (squash)
October 27, 2026 17:10
0101
approved these changes
Oct 27, 2026
Preserve main's localization updates and regenerate the no-selection message. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
0101
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconcile all four open
area-vendored-syncreports against the verified upstream revision3c6614c5ae19ee4ddca55cbf9b3375bbaad3496b.AssemblyRunNotSelectedand wire it to successful affected-run orchestrators that never start a TestHost. Render a neutralNo affected tests selectedstatus without inventing skipped tests.Zero tests ranwording instead of a greenPassed!verdict. Preserve real failures and the SDK's authoritative aggregate exit code.AllowZeroTestsoption, clarify its contract, and document why the SDK uses final aggregate exit codes instead of the upstream in-processHasTestSessionFailurecallback and globalZeroTestsPolicyoption.DisplayMessageforwarding verbatim.Update each reviewed source's exact commit/blob baseline and adaptation notes, regenerate all 13 CLI localization files through
UpdateXlf, and document the SDK-specific reporting invariant.Compatibility
No wire IDs, advertised protocol versions, dependency versions, or feature gates change. The existing experimental affected-test gate remains in place. Mapping collection does not emit a no-selection status; rejected/partial handshakes, help/discovery, cancellation, and unsuccessful orchestrator exits cannot become benign no-selection results. Session failures, per-module policies, ignored exit codes, and failures in other modules retain their existing exit-code semantics.
This targets
main; it does not enable a downstream feature or introduce a producer/consumer rollout requiring a servicing backport.Validation
Components: bootstrap SDK
12.0.100-alpha.1.26480.102, built SDK12.0.100-dev/net12.0, and the repository-alignedMicrosoft.Testing.Platformpackage2.6.0-preview.26519.1(testfx revisiond25ab5d76da4d7202291e5d1af1070b5496751a9). Confirmed that the deployeddotnet.dllmatches the freshly built assembly before testing.Successful managed layout build, exit 0:
This machine lacks the MSVC/C++ prerequisites, so local verification disables native publishing. Native AOT publishing is not claimed; the changed command implementation is managed. Serial building also avoids concurrent managed/AOT projects writing the same XLF files.
Focused runner, exit 0: 176 passed, 0 failed, 0 skipped.
The new composed-product tests use a real MTP execution orchestrator, its command-line registration, and the actual named-pipe transport—not mocked SDK handlers. They verify affected-run and mapping-collection success (host/parent exit
0), nonzero orchestrator failures (1), a zero-test orchestrator exit without a TestHost (8becomes parent failure1), and framework session creation/closure failures (10). Existing cases cover ordinary successes, unexpected empty runs, strict/ignored zero-test policies, and mixed empty/passing modules. Unit cases retain legacy, partial/rejected handshake, discovery/help, and cancellation boundaries.Additional successful checks:
Verified all four upstream blob identities, preserved source indexes and unrelated manifest entries, checked all generated localization entries, and resolved all local links in the changed guidance. Retained test artifacts:
artifacts\log\test-runs\dotnet.Tests\20261027-125533-81972\test-results.trxandbuild.binlog; layout/localization binlogs are at the paths above.Fixes #56696
Fixes #56697
Fixes #56698
Fixes #56786