Skip to content

Reconcile outstanding MTP vendoring updates - #56802

Merged
Evangelink merged 2 commits into
mainfrom
dev/amauryleve/mtp-constants-sync
Oct 29, 2026
Merged

Evangelink merged 2 commits into
mainfrom
dev/amauryleve/mtp-constants-sync

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

Reconcile all four open area-vendored-sync reports against the verified upstream revision 3c6614c5ae19ee4ddca55cbf9b3375bbaad3496b.

Report Reconciliation
#56696 Port AssemblyRunNotSelected and wire it to successful affected-run orchestrators that never start a TestHost. Render a neutral No affected tests selected status without inventing skipped tests.
#56697 Render successful zero-test runs with neutral Zero tests ran wording instead of a green Passed! verdict. Preserve real failures and the SDK's authoritative aggregate exit code.
#56698 Retain the already-supported AllowZeroTests option, clarify its contract, and document why the SDK uses final aggregate exit codes instead of the upstream in-process HasTestSessionFailure callback and global ZeroTestsPolicy option.
#56786 Mirror the comment-only clarification that GitHub Actions workflow commands use informational DisplayMessage forwarding verbatim.

Update each reviewed source's exact commit/blob baseline and adaptation notes, regenerate all 13 CLI localization files through UpdateXlf, and document the SDK-specific reporting invariant.

Compatibility

No wire IDs, advertised protocol versions, dependency versions, or feature gates change. The existing experimental affected-test gate remains in place. Mapping collection does not emit a no-selection status; rejected/partial handshakes, help/discovery, cancellation, and unsuccessful orchestrator exits cannot become benign no-selection results. Session failures, per-module policies, ignored exit codes, and failures in other modules retain their existing exit-code semantics.

This targets main; it does not enable a downstream feature or introduce a producer/consumer rollout requiring a servicing backport.

Validation

Components: bootstrap SDK 12.0.100-alpha.1.26480.102, built SDK 12.0.100-dev / net12.0, and the repository-aligned Microsoft.Testing.Platform package 2.6.0-preview.26519.1 (testfx revision d25ab5d76da4d7202291e5d1af1070b5496751a9). Confirmed that the deployed dotnet.dll matches the freshly built assembly before testing.

Successful managed layout build, exit 0:

$env:DOTNET_ADD_GLOBAL_TOOLS_TO_PATH = '0'
$env:DOTNET_CLI_TELEMETRY_OPTOUT = '1'
& .\eng\build.ps1 /p:PublishAot=false /p:_ShouldPublishDotnetAot=false /m:1 /bl:artifacts\log\vendoring-layout.binlog /v:minimal

This machine lacks the MSVC/C++ prerequisites, so local verification disables native publishing. Native AOT publishing is not claimed; the changed command implementation is managed. Serial building also avoids concurrent managed/AOT projects writing the same XLF files.

Focused runner, exit 0: 176 passed, 0 failed, 0 skipped.

$filter = 'FullyQualifiedName~TerminalTestReporterTests|FullyQualifiedName~TestApplicationHandlerTests|FullyQualifiedName~TestApplicationActionQueueTests|FullyQualifiedName~RunAffectedTestsWithoutTestHost_ReportsSelectionAndSummary|FullyQualifiedName~RunTestSessionFailure_ShouldNotReportPassedSummary|FullyQualifiedName~RunTestProjectWithNoTests_ShouldReturnExitCodeZeroTests|FullyQualifiedName~RunNoTestsHonorsIgnoredExitCodeFromExplicitConfigurationFile|FullyQualifiedName~RunTestProjectWithTests_ShouldReturnExitCodeSuccess|FullyQualifiedName~RunMultipleTestProjectsWhereOneRanZeroTests_ShouldReturnExitCodeSuccess|FullyQualifiedName~RunAllSkippedTestsHonorsZeroTestsAndIgnoreExitCodePolicies'
.\.dotnet\dotnet.exe scripts\RunTests.cs -- --project test\dotnet.Tests\dotnet.Tests.csproj --filter $filter

The new composed-product tests use a real MTP execution orchestrator, its command-line registration, and the actual named-pipe transport—not mocked SDK handlers. They verify affected-run and mapping-collection success (host/parent exit 0), nonzero orchestrator failures (1), a zero-test orchestrator exit without a TestHost (8 becomes parent failure 1), and framework session creation/closure failures (10). Existing cases cover ordinary successes, unexpected empty runs, strict/ignored zero-test policies, and mixed empty/passing modules. Unit cases retain legacy, partial/rejected handshake, discovery/help, and cancellation boundaries.

Additional successful checks:

.\.dotnet\dotnet.exe msbuild src\Cli\dotnet\dotnet.csproj /t:UpdateXlf /p:Configuration=Debug /p:TargetFramework=net12.0 /nologo /v:minimal /bl:artifacts\log\vendoring-update-xlf.binlog
python .github\scripts\check_vendored_files.py validate
git diff --check

Verified all four upstream blob identities, preserved source indexes and unrelated manifest entries, checked all generated localization entries, and resolved all local links in the changed guidance. Retained test artifacts: artifacts\log\test-runs\dotnet.Tests\20261027-125533-81972\test-results.trx and build.binlog; layout/localization binlogs are at the paths above.

Fixes #56696
Fixes #56697
Fixes #56698
Fixes #56786

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evangelink requested review from a team, lbussell and mthalman as code owners October 27, 2026 13:01
Copilot AI balanced review requested due to automatic review settings October 27, 2026 13:01
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the reporting and vendoring updates.

No open issues 🎉

What changed in this PR

Reconciles four Microsoft.Testing.Platform vendoring reports in the SDK’s dotnet test implementation, adapting upstream reporting changes while preserving aggregate exit-code semantics and existing protocol support.

Changes:

  • Adds neutral “No affected tests selected” output for successful affected-run orchestrators that never start a test host, and “Zero tests ran” summaries for successful empty runs.
  • Expands unit and integration coverage for no-selection, cancellation, session failures, and ignored exit-code policies.
  • Updates vendoring baselines, reporting guidance, and 13 localization files; clarifies GitHub Actions message forwarding in comments only.
File Description
test/​dotnet.Tests/​CommandTests/​Test/​TestApplicationHandlerTests.cs Covers no-selection output, cancellation, and aggregate failures.
test/​dotnet.Tests/​CommandTests/​Test/​TerminalTestReporterTests.cs Verifies neutral statuses, summary colors, and session failures.
test/​dotnet.Tests/​CommandTests/​Test/​GivenDotnetTestBuildsAndRunsTests.cs Adds orchestrator and session-failure integration coverage.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.zh-Hant.xlf Adds Traditional Chinese localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.zh-Hans.xlf Adds Simplified Chinese localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.tr.xlf Adds Turkish localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.ru.xlf Adds Russian localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.pt-BR.xlf Adds Brazilian Portuguese localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.pl.xlf Adds Polish localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.ko.xlf Adds Korean localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.ja.xlf Adds Japanese localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.it.xlf Adds Italian localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.fr.xlf Adds French localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.es.xlf Adds Spanish localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.de.xlf Adds German localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​xlf/​CliCommandStrings.cs.xlf Adds Czech localization entry awaiting translation.
src/​Cli/​dotnet/​Commands/​Test/​MTP/​TestApplicationHandler.cs Connects successful affected-run completion to no-selection reporting.
src/​Cli/​dotnet/​Commands/​Test/​MTP/​Terminal/​TerminalTestReporterOptions.cs Clarifies the existing AllowZeroTests contract.
src/​Cli/​dotnet/​Commands/​Test/​MTP/​Terminal/​TerminalTestReporter.cs Implements neutral no-selection and successful zero-test output.
src/​Cli/​dotnet/​Commands/​Test/​CliConstants.cs Clarifies GitHub Actions forwarding comments without protocol changes.
src/​Cli/​dotnet/​Commands/​CliCommandStrings.resx Defines the no-selection message and translator guidance.
src/​Cli/​AGENTS.md Documents neutral reporting and aggregate exit-code authority.
eng/​vendored-files.json Updates four upstream baselines and SDK adaptation notes.

Review effort: Balanced

@Evangelink
Evangelink enabled auto-merge (squash) October 27, 2026 17:10
Preserve main's localization updates and regenerate the no-selection message.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@Evangelink
Evangelink merged commit 5b33f2b into main Oct 29, 2026
27 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/mtp-constants-sync branch October 29, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants