Repository navigation
[release/11.0.1xx] Bundle Roslyn ProjectData tasks and import them through the SDK (#56243) - #56354
Merged
jasonmalinowski merged 1 commit intoSep 21, 2026
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The ProjectData package versions differ between Version.Details.xml and Version.Details.props; regenerate the dependency-flow outputs.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Bundles Roslyn ProjectData tasks into the SDK so builds can generate .lscache files when enabled.
Changes:
- Adds ProjectData packaging and SDK layout integration.
- Imports ProjectData targets through
Sdk.targets. - Adds enabled, disabled, and multi-target integration tests.
- Adds dependency-flow and central package-version metadata.
| File | Reviewed change |
|---|---|
test/Microsoft.NET.Build.Tests/GivenThatWeWantToUseProjectData.cs |
Adds ProjectData integration coverage. |
src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets |
Imports bundled ProjectData targets. |
src/Layout/redist/tools/tool_projectdata.csproj |
Packages ProjectData assets. |
src/Layout/redist/targets/GenerateLayout.targets |
Publishes ProjectData into the SDK layout. |
src/Layout/redist/redist.csproj |
Adds the ProjectData build dependency. |
eng/Version.Details.xml |
Declares the ProjectData dependency. |
eng/Version.Details.props |
Defines ProjectData package version properties. |
Directory.Packages.props |
Registers central package versioning. |
JoeRobich
reviewed
Sep 18, 2026
…et#56243) This bundles the ProjectData/lscache tests into the SDK, so lscache files can be generated if EnableProjectDataOnBuild is enabled.
jasonmalinowski
force-pushed
the
backport-projectdata-to-11.0
branch
from
September 18, 2026 21:37
40053bd to
cb8c6fc
Compare
Member
|
/tactics |
baronfel
approved these changes
Sep 21, 2026
jasonmalinowski
merged commit Sep 21, 2026
ddd0f75
into
dotnet:release/11.0.1xx
23 of 24 checks passed
This was referenced Sep 21, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Backport of the PR from main which needed hand merge resolution in the version.props files.
Description
This adds a new feature to the SDK for producing lscache files during a build. These files are currently built by DevKit with MSBuild tasks and targets that are injected into builds by the DevKit extension; this simply moves those tasks/targets into the SDK. The feature is currently gated behind an MSBuild property which off by default.
The eventual customer impact is for customers who turn this feature on, doing a build and then opening an IDE will allow much faster loads, since we will have already built caches needed for fast loading.
Regression
Risk
Low -- this code is already shipping in DevKit's release channel as of last week, and the feature is gated behind an opt-in flag.
Testing
New automated tests were added that verify the lscache files are only created when the feature is enabled (and are not created when disabled). The CI build from this PR was also downloaded and smoke tested as well.