Skip to content

[release/11.0.1xx] Bundle Roslyn ProjectData tasks and import them through the SDK (#56243) - #56354

Merged
jasonmalinowski merged 1 commit into
dotnet:release/11.0.1xxfrom
jasonmalinowski:backport-projectdata-to-11.0
Sep 21, 2026
Merged

jasonmalinowski merged 1 commit into
dotnet:release/11.0.1xxfrom
jasonmalinowski:backport-projectdata-to-11.0

Conversation

@jasonmalinowski

@jasonmalinowski jasonmalinowski commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

Backport of the PR from main which needed hand merge resolution in the version.props files.

Description

This adds a new feature to the SDK for producing lscache files during a build. These files are currently built by DevKit with MSBuild tasks and targets that are injected into builds by the DevKit extension; this simply moves those tasks/targets into the SDK. The feature is currently gated behind an MSBuild property which off by default.

The eventual customer impact is for customers who turn this feature on, doing a build and then opening an IDE will allow much faster loads, since we will have already built caches needed for fast loading.

Regression

  • No -- it's a new feature behind an opt-in setting

Risk

Low -- this code is already shipping in DevKit's release channel as of last week, and the feature is gated behind an opt-in flag.

Testing

New automated tests were added that verify the lscache files are only created when the feature is enabled (and are not created when disabled). The CI build from this PR was also downloaded and smoke tested as well.

@jasonmalinowski jasonmalinowski self-assigned this Sep 18, 2026
Copilot AI lite review requested due to automatic review settings September 18, 2026 21:11
@jasonmalinowski
jasonmalinowski requested a review from a team as a code owner September 18, 2026 21:11
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@jasonmalinowski jasonmalinowski changed the title Bundle Roslyn ProjectData tasks and import them through the SDK (#56243) [release/11.0.1xx] Bundle Roslyn ProjectData tasks and import them through the SDK (#56243) Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The ProjectData package versions differ between Version.Details.xml and Version.Details.props; regenerate the dependency-flow outputs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Bundles Roslyn ProjectData tasks into the SDK so builds can generate .lscache files when enabled.

Changes:

  • Adds ProjectData packaging and SDK layout integration.
  • Imports ProjectData targets through Sdk.targets.
  • Adds enabled, disabled, and multi-target integration tests.
  • Adds dependency-flow and central package-version metadata.
File Reviewed change
test/​Microsoft.NET.Build.Tests/​GivenThatWeWantToUseProjectData.cs Adds ProjectData integration coverage.
src/​Tasks/​Microsoft.NET.Build.Tasks/​sdk/​Sdk.targets Imports bundled ProjectData targets.
src/​Layout/​redist/​tools/​tool_projectdata.csproj Packages ProjectData assets.
src/​Layout/​redist/​targets/​GenerateLayout.targets Publishes ProjectData into the SDK layout.
src/​Layout/​redist/​redist.csproj Adds the ProjectData build dependency.
eng/​Version.Details.xml Declares the ProjectData dependency.
eng/​Version.Details.props Defines ProjectData package version properties.
Directory.Packages.props Registers central package versioning.

Comment thread eng/Version.Details.props Resolved
Comment thread eng/Version.Details.xml Resolved
…et#56243)

This bundles the ProjectData/lscache tests into the SDK, so lscache files can be generated if EnableProjectDataOnBuild is enabled.
@jasonmalinowski
jasonmalinowski force-pushed the backport-projectdata-to-11.0 branch from 40053bd to cb8c6fc Compare September 18, 2026 21:37
@baronfel

Copy link
Copy Markdown
Member

/tactics

@jasonmalinowski jasonmalinowski added this to the 11.0-rc2 milestone Sep 21, 2026
@jasonmalinowski
jasonmalinowski merged commit ddd0f75 into dotnet:release/11.0.1xx Sep 21, 2026
23 of 24 checks passed
@jasonmalinowski
jasonmalinowski deleted the backport-projectdata-to-11.0 branch September 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants