Repository navigation
Honor configured MTP exit policies - #56304
Merged
Evangelink merged 1 commit intoSep 15, 2026
Merged
Evangelink merged 1 commit into
Evangelink merged 1 commit into
Conversation
Reconstruct zero-test and ignored-exit policies from explicit and default test configuration files, and match process environment casing and override order on Windows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add coverage for Unix-sensitive casing and module environment overrides.
Get a fresh assessment by requesting another Copilot review.
Review tier: Lite
Findings: 1
Open (1)
What changed in this PR
Updates dotnet test to honor effective MTP policies when computing aggregate test results.
Changes:
- Reads explicit/default
.testconfig.jsonpolicies. - Preserves environment, CLI, and JSON precedence.
- Adds parser and end-to-end coverage.
| File | Summary |
|---|---|
test/dotnet.Tests/CommandTests/Test/TestCommandParserTests.cs |
Tests ignored-exit-code precedence. |
test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs |
Adds configuration and launch-profile integration coverage. |
src/Cli/dotnet/Commands/Test/MTP/MicrosoftTestingPlatformTestCommand.cs |
Reconstructs effective MTP policies. |
YuliiaKovalova
approved these changes
Sep 15, 2026
Evangelink
had a problem deploying
to
copilot-pat-pool
September 15, 2026 14:23 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Follow up on #56219 and #56296 so the SDK aggregate verdict uses the same effective MTP policy as the test application.
zero-tests-policyandignore-exit-codefrom explicit and default.testconfig.jsonfilesProcessStartInfoValidation
build.cmd: passed with 0 warnings and 0 errorsdotnet.Tests: 222 passed, 0 failed, 0 skipped