Skip to content

Use GitHub app for pushing to the VMR during synchronization - #55698

Merged
mthalman merged 1 commit into
dotnet:release/9.0.1xxfrom
premun:prvysoky/vmr-sync-gh-app
Aug 11, 2026
Merged

mthalman merged 1 commit into
dotnet:release/9.0.1xxfrom
premun:prvysoky/vmr-sync-gh-app

Conversation

@premun

@premun premun commented Aug 10, 2026

Copy link
Copy Markdown
Member

Copilot AI lite review requested due to automatic review settings August 10, 2026 13:55
@premun
premun requested review from a team as code owners August 10, 2026 13:55
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VMR synchronization job to authenticate GitHub pushes to dotnet/dotnet using a GitHub App installation token (minted from Azure Key Vault) instead of a long-lived bot PAT, aligning with the direction in dotnet/arcade-services#6531.

Changes:

  • Replaces the DotNetBot-GitHub variable group with VMR Synchronization - Push for VMR push credentials.
  • Adds a get-github-app-token.yml step to mint a short-lived GitHub App installation token.
  • Switches darc vmr push --github-pat to use the minted token ($(vmrPushToken)).

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@mthalman mthalman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport this to release/8.0.1xx as well.

@premun

premun commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

That's the plan. Though it will have to go to installer's 8.0

@premun

premun commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@mthalman can you help me merge this one? Seems like one leg times out over a Helix queue that is too deep atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants