Skip to content

Conversation

@edvilme
Copy link
Contributor

@edvilme edvilme commented Mar 6, 2025

Fixes #47297

Copilot AI review requested due to automatic review settings March 6, 2025 19:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@mthalman
Copy link
Member

mthalman commented Mar 7, 2025

@edvilme - It wasn't made known in dotnet/source-build-externals#454 that this was for 9.0. That PR will need to be backported to the 9.0 branch.

@edvilme
Copy link
Contributor Author

edvilme commented Mar 7, 2025

Re targeting to 9.0.3xx

@edvilme edvilme changed the base branch from release/9.0.2xx to release/9.0.3xx March 7, 2025 19:34
@edvilme
Copy link
Contributor Author

edvilme commented Mar 7, 2025

@edvilme - It wasn't made known in dotnet/source-build-externals#454 that this was for 9.0. That PR will need to be backported to the 9.0 branch.

Backport ready at dotnet/source-build-externals#456

@mthalman
Copy link
Member

mthalman commented Mar 7, 2025

Dependency flow for 9.0.1xx is here: #47364.

@kasperk81
Copy link
Contributor

@akoeplinger should this pr revert 595df90?

@akoeplinger
Copy link
Member

@kasperk81 I think we actually need the msbuild bump first since the test broke in that dependency flow so it seems to be using the vs-solutionpersistence from there.

…als (dotnet#47364)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit c35d72a)
@kasperk81
Copy link
Contributor

msbuild update is #47385

@akoeplinger akoeplinger merged commit 5a93642 into dotnet:release/9.0.3xx Mar 8, 2025
30 checks passed
akoeplinger pushed a commit that referenced this pull request Mar 9, 2025
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit 5a93642)
akoeplinger pushed a commit that referenced this pull request Mar 10, 2025
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit 5a93642)
edvilme added a commit that referenced this pull request Mar 11, 2025
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
(cherry picked from commit 5a93642)
@renovate renovate bot mentioned this pull request Jun 21, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-NetSDK untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants