[release/6.0.1xx] Update BlazorWebAssembly targets to work with updated wasm targets #20742
Conversation
ghost
added
the
|
@javiercn @pranavkm @captainsafia The changes here might not be the best way to get the results, so please feel free to change that. But with this, I can build blazorwasm projects with native libraries, which should allow debugging with VS. |
|
cc @lewing |
radical
force-pushed
the
blazor-build-publish-6.0.1
branch
from
5ebb9cc to
0e42b90
Compare
|
@radical do you think we can have a meeting to discuss these changes? I think we can probably find a more streamlined way to integrate these changes but I need a bit more context I think. |
radical
force-pushed
the
blazor-build-publish-6.0.1
branch
from
0e42b90 to
df88d57
Compare
[This PR](dotnet/runtime#57556) adds support for relinking the native wasm files during the build (instead of only during publish). This required changes to the targets available, and how they can be used, and thus require changes in the blazor targets to work with that. The new setup is explained in https://github.com/radical/runtime/blob/wasm-build/src/mono/wasm/build/README.md .
radical
force-pushed
the
blazor-build-publish-6.0.1
branch
from
df88d57 to
382f23d
Compare
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets
Outdated
Show resolved
Hide resolved
1. Ensure that the PublishDir uses the same case as PublishUrl, to workaround a bug where we end up with two directories on linux: `Publish`, and `publish`. dotnet#20923 2. Add all the `@(WasmNativeAssets)` as candidates, and not just `.wasm` 3. And update to track property name change
src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets
Outdated
Show resolved
Hide resolved
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Overall changes look good.
I'm signing off to make sure things are unblocked (provided tests pass and trusting manual verification of the AoT scenarios has happened before merging.
|
The corresponding runtime PR dotnet/runtime#58913 has merged. Next is to wait for a version bump PR to be opened. |
radical
changed the title
|
I believe this'll need to be cherry-picked into |
4 participants
This runtime PR adds support for
relinking the native wasm files during the build (instead of only during
publish).
This required changes to the targets available, and how they can be
used, and thus require changes in the blazor targets to work with that.
The new setup is explained in
https://github.com/radical/runtime/blob/wasm-build/src/mono/wasm/build/README.md
.
This will need to be merged after dotnet/runtime#57556 goes in.