Fix workloads build by bringing back some needed variables #99932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#99179 made some changes and switched the template the workloads build was using. In the process, workloadArtifactsPath and workloadPackagesPath got dropped, which meant the workloads build did not pick up any manifests to process. As a result, the build failed.
ghost
added
the
Member
Author
|
official build running https://dev.azure.com/dnceng/internal/_build/results?buildId=2407574&view=results |
lewing
approved these changes
Mar 18, 2024
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
Changes look fine, hopefully we don't need any of the others.
ericstj
approved these changes
Mar 18, 2024
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
LGTM modulo one extraneous variable.
ViktorHofer
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#99179 made some changes and switched the template the workloads build was using. In the process, workloadArtifactsPath and workloadPackagesPath got dropped, which meant the workloads build did not pick up any manifests to process. As a result, the build failed.