Backport VMR patch for cross builds #99702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport the VMR patch that fixed our cross-build issues.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
ViktorHofer
approved these changes
Mar 13, 2024
ViktorHofer
reviewed
Mar 13, 2024
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
@jkoritzinsky I just noticed that we already pass the -cross switch in:
Line 50 in 44442a1
Member
Author
|
That condition isn't correct for the x64 cross build. I'll merge the two conditions. |
ViktorHofer
approved these changes
Mar 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the VMR patch that fixed our cross-build issues.