JIT: Handle GT_SWIFT_ERROR in gtCloneExpr

[amanasifkhalid]

Fixes #99214 by handling GT_SWIFT_ERROR in Compiler::gtCloneExpr.

cc @jakobbotsch. Since this isn't the first time an outerloop pipeline has failed due to a missing GT_SWIFT_ERROR switch case, I tried to look for other missing cases by searching for similarly-handled GenTree nodes. It's not the most precise method, but I did notice we aren't explicitly handling GT_SWIFT_ERROR in GenTree::Compare -- we return false if we encounter it. Just to check, is this the correct behavior, since GT_SWIFT_ERROR represents a value unknown at compile time?

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #99214 by handling GT_SWIFT_ERROR in Compiler::gtCloneExpr.

cc @jakobbotsch. Since this isn't the first time an outerloop pipeline has failed due to a missing GT_SWIFT_ERROR switch case, I tried to look for other missing cases by searching for similarly-handled GenTree nodes. It's not the most precise method, but I did notice we aren't explicitly handling GT_SWIFT_ERROR in GenTree::Compare -- we return false if we encounter it. Just to check, is this the correct behavior, since GT_SWIFT_ERROR represents a value unknown at compile time?

Author:	amanasifkhalid
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[amanasifkhalid]

/azp run runtime-coreclr jitstress-random

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

Fixes #99214 by handling GT_SWIFT_ERROR in Compiler::gtCloneExpr.

cc @jakobbotsch. Since this isn't the first time an outerloop pipeline has failed due to a missing GT_SWIFT_ERROR switch case, I tried to look for other missing cases by searching for similarly-handled GenTree nodes. It's not the most precise method, but I did notice we aren't explicitly handling GT_SWIFT_ERROR in GenTree::Compare -- we return false if we encounter it. Just to check, is this the correct behavior, since GT_SWIFT_ERROR represents a value unknown at compile time?

GenTree::Compare can return true for it. It is a syntactic check -- it also returns true for two syntactically equal calls or indirections even though those can return different values.

[amanasifkhalid]

GenTree::Compare can return true for it. It is a syntactic check -- it also returns true for two syntactically equal calls or indirections even though those can return different values.

I see, thanks for letting me know -- I'll update it separately.

[amanasifkhalid]

jitstress-random passed.