Preserve all InternalsVisibleTo attributes in ILLink Trimmer #98910
Conversation
ghost
added
the
area-Tools-ILLink
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsRemoves previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes #92582
|
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
fa9da15 to
dbd86c0
Compare
|
@dotnet-policy-service agree |
teo-tsirpanis
added
the
community-contribution
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
2 times, most recently
from
4d7d955 to
2edac38
Compare
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
2edac38 to
048a932
Compare
dotnet-policy-service
bot
added
the
linkable-framework
src/tools/illink/test/Mono.Linker.Tests.Cases/Attributes/IVTUnused.cs
Outdated
Show resolved
Hide resolved
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
048a932 to
25906e9
Compare
Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes dotnet#92582
Xtansia
force-pushed
the
fix/preserve-ivt-attributes
branch
from
25906e9 to
9144ba6
Compare
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
|
@sbomer is this waiting for someone else's review? |
|
Nope, merged. |
|
Thanks @sbomer. Is there any follow up actions required from my end? What sort of timeline could I expect to see this included in a release? |
|
No action required. You should see it included in the next .NET 9 preview release (preview 4). |
…98910) Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction. Fixes dotnet#92582
4 participants
Removes previous special handling to only keep IVT attributes for assemblies that were resolvable and marked at link time. This behaviour could cause a noticeable difference in behaviour at runtime without emitting any trim analysis warnings while providing no mechanism to retain the attributes. The removal of these attributes provides only a neglible size reduction.
Fixes #92582