Remove the MarshallingGeneratorFactoryKey type and construct the generator factory during the "source emit" stage #93034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator factory during the 'source emit' stage.
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
jtschuster
ghost
assigned
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsNow that we track "is runtime marshalling disabled" via a simple flag and we do not calculate it from the Compilation object, we can avoid using the Compilation when creating the IMarshallingGeneratorFactory. As a result, we can move where we construct the object to the stage where it's actually used and avoid having to create custom equality operators and other cleverness to keep our models incremental.
|
jtschuster
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we track "is runtime marshalling disabled" via a simple flag and we do not calculate it from the Compilation object, we can avoid using the Compilation when creating the IMarshallingGeneratorFactory. As a result, we can move where we construct the object to the stage where it's actually used and avoid having to create custom equality operators and other cleverness to keep our models incremental.