Skip to content

[mono][ios] Call mono_gc_init_finalizer_thread to allow gc thread creation #91785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 2 commits into from
Sep 8, 2023
Merged

[mono][ios] Call mono_gc_init_finalizer_thread to allow gc thread creation #91785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2becc17
Invoke mono_gc_init_finalizer_thread from the embedder to create the …
kotlarmilos Sep 8, 2023
1c282dc
Enable runtime test
kotlarmilos Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/tasks/AppleAppBuilder/Templates/runtime.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,7 @@ static bool is_pinvoke_override_library (const char* libraryName)
MonoDomain *domain = mono_jit_init_version ("dotnet.ios", "mobile");
assert (domain);

#if !FORCE_INTERPRETER && (!TARGET_OS_SIMULATOR || FORCE_AOT)
// device runtimes are configured to use lazy gc thread creation
mono_gc_init_finalizer_thread ();
#endif

MonoAssembly *assembly = load_assembly (executable, NULL);
assert (assembly);
Expand Down
3 changes: 0 additions & 3 deletions src/tests/issues.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3699,9 +3699,6 @@
<ExcludeList Include="$(XunitTestBinBase)/GC/Regressions/v2.0-beta1/149926/149926/*">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/tracing/eventpipe/gcdump/**">
<Issue>https://github.com/dotnet/runtime/issues/90012</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Loader/CustomAttributes/**">
<Issue>Dynamic code generation is not supported on this platform</Issue>
</ExcludeList>
Expand Down