Add -skipcrossarchnative and -verbose options #90554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-Infrastructure-coreclr
community-contribution
|
Tagging subscribers to this area: @hoyosjs Issue DetailsBuild.sh lacks -skipcrossarchnative and -verbose for coreclr building so let's add these 2 options to be forwarded to coreclr build system.
|
giuliobenetti
force-pushed
the
add/skipcrossarchnative-and-verbose-options
branch
from
10c070e to
8c8667f
Compare
Contributor
Author
|
Kindly ping this PR. Do the patches look good? |
hoyosjs
reviewed
Sep 25, 2023
hoyosjs
reviewed
Sep 25, 2023
Sponsored by: Tekvox Inc. Cc: Jim Reinhart <[email protected]> Cc: James Autry <[email protected]> Cc: Matthew Maron <[email protected]> Signed-off-by: Giulio Benetti <[email protected]>
During commit 7d562f9 comment about -skipcrossarchnative has been forgotten, so let's remove it since that flag is not available anymore. Signed-off-by: Giulio Benetti <[email protected]>
giuliobenetti
force-pushed
the
add/skipcrossarchnative-and-verbose-options
branch
from
8c8667f to
694812a
Compare
hoyosjs
reviewed
Sep 25, 2023
hoyosjs
approved these changes
Sep 25, 2023
giuliobenetti
commented
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.sh lacks -skipcrossarchnative and -verbose for coreclr building so let's add these 2 options to be forwarded to coreclr build system.