Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented May 10, 2023

No description provided.

@jkotas jkotas requested a review from MichalStrehovsky as a code owner May 10, 2023 18:56
@ghost ghost assigned jkotas May 10, 2023
@ghost ghost added the area-VM-coreclr label May 10, 2023
@jkotas
Copy link
Member Author

jkotas commented May 10, 2023

Continuation of #85947

@jkotas jkotas requested a review from BruceForstall May 10, 2023 18:56
@vcsjones
Copy link
Member

docs/workflow/README.md "Build Requirements" should have the table updated to indicate ARM is not supported on Windows (and maybe change ARM to ARM32 so as not to be ambiguous).

@EgorBo
Copy link
Member

EgorBo commented May 10, 2023

Presumably we can also close all active win-arm32 issues (not all of them have OS label)?

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Additional things to remove:

  1. in root .vsconfig, presumably we can remove "Microsoft.VisualStudio.Component.VC.Tools.ARM"
  2. remove "arm" case from src\coreclr\build-runtime.cmd
  3. Remove win-arm32 cross-components builds case from eng\Subsets.props. I think that would be:
  <ItemGroup Condition="(('$(ClrRuntimeBuildSubsets)' != '' and '$(PrimaryRuntimeFlavor)' == 'CoreCLR' and '$(TargetsMobile)' != 'true') or $(_subset.Contains('+clr.crossarchtools+'))) and $([MSBuild]::IsOsPlatform(Windows)) and '$(TargetArchitecture)' == 'arm' and '$(BuildArchitecture)' == 'x64'">
    <ProjectToBuild
      Include="$(CoreClrProjectRoot)runtime.proj"
      AdditionalProperties="%(AdditionalProperties);
                            ClrCrossComponentsSubset=true;
                            HostArchitecture=x86;
                            PgoInstrument=false;
                            NoPgoOptimize=true;
                            CrossBuild=false;
                            CMakeArgs=$(CMakeArgs) -DCLR_CROSS_COMPONENTS_BUILD=1"
      Category="clr" />
  </ItemGroup>

@jkotas
Copy link
Member Author

jkotas commented May 11, 2023

Presumably we can also close all active win-arm32 issues (not all of them have OS label)?

Yes, we have been closing win-arm32 issues as won't fix for a while now. If there are any still left, feel free to close them.

@jkotas jkotas merged commit 418aa8a into dotnet:main May 11, 2023
@jkotas jkotas deleted the arm32 branch May 12, 2023 01:53
directhex added a commit to directhex/llvm-project that referenced this pull request May 23, 2023
directhex added a commit to dotnet/llvm-project that referenced this pull request May 23, 2023
* Remove Windows arm32 packages.

Ref: dotnet/runtime#86065

* Remove some windows-arm stuff from llvm.proj
directhex added a commit to directhex/llvm-project that referenced this pull request Jun 2, 2023
* Remove Windows arm32 packages.

Ref: dotnet/runtime#86065

* Remove some windows-arm stuff from llvm.proj

(cherry picked from commit c01ca3b)
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants