Rename cgroup.cpp to cgroupcpu.cpp #83029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, two objects (.o) with same name are linked in a static library (
gc/unix/cgroup.cppandnativeaot/Runtime/unix/cgroup.cpp) and the linkage order of objects is nondeterministic. When such a static library is linked into the final object on macOS (executable or library), and we rundsymutilon it to strip its symbols,dsymutildoes not look past the first object by name and intermittently warns about missing symbols when the linkage order was reversed. That warning turns into error in NativeAOT publishing process.Simplest fix is to rename the source file to disambiguate the output object filename.
Also refactor the code a bit: instead of using header for InitializeCpuCGroup and extern for GetCpuLimit, use header for both APIs.
Revert #82881
Fix #80934