Skip to content

Conversation

@sec
Copy link
Contributor

@sec sec commented Jan 31, 2023

After merge of #80323 build for FreeBSD arm64 broke. This PR adds missing MCREGs defines for FreeBSD/arm64 to make it compile. @Thefrank @janvorli

@sec sec requested a review from MichalStrehovsky as a code owner January 31, 2023 00:15
@ghost ghost added area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member labels Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

After merge of #80323 build for FreeBSD arm64 broke. This PR adds missing MCREGs defines for FreeBSD/arm64 to make it compile. @Thefrank @janvorli

Author: sec
Assignees: -
Labels:

community-contribution, area-NativeAOT-coreclr

Milestone: -

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit. Thank you!

@sec sec mentioned this pull request Jan 31, 2023
@janvorli janvorli merged commit 8582762 into dotnet:main Jan 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2023
@sec sec deleted the fix.freebsd.arm64.build branch February 18, 2024 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants