Fix Equals in hot reload scenario #78249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsWhile fixing Hot Reload breaks MethodInfo equality we caused regression in PropertyInfo, FieldInfo and EventInfo. See details: Huge Breaking Issue in Net7 with MemberInfo equality Fixes: #78218
|
steveharter
reviewed
Nov 11, 2022
src/libraries/System.Runtime/tests/System/Reflection/ReflectionCacheTests.cs
Show resolved
Hide resolved
jkotas
approved these changes
Nov 11, 2022
…nCacheTests.cs Co-authored-by: Steve Harter <[email protected]>
AaronRobinsonMSFT
approved these changes
Nov 11, 2022
Contributor
Author
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3448761127 |
steveharter
approved these changes
Nov 12, 2022
Contributor
Author
|
The failure unrelated and reported, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing Hot Reload breaks MethodInfo equality we caused regression in PropertyInfo, FieldInfo and EventInfo.
See details: Huge Breaking Issue in Net7 with MemberInfo equality
Fixes: #78218