Skip to content

[release/6.0] [wasm][debugger] Never send messages from our internal protocol extensions to the browser #77620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlossanlop merged 1 commit into from
Nov 3, 2022
Merged

[release/6.0] [wasm][debugger] Never send messages from our internal protocol extensions to the browser #77620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,10 @@ protected override async Task<bool> AcceptCommand(MessageId id, string method, J
await AttachToTarget(id, token);

if (!contexts.TryGetValue(id, out ExecutionContext context))
return false;
{
// for Dotnetdebugger.* messages, treat them as handled, thus not passing them on to the browser
return method.StartsWith("DotnetDebugger.", StringComparison.OrdinalIgnoreCase);
}

switch (method)
{
Expand Down Expand Up @@ -536,11 +539,8 @@ protected override async Task<bool> AcceptCommand(MessageId id, string method, J
}
}

//ignore all protocol extension messages not supported on .net6
if (method.StartsWith("DotnetDebugger.", StringComparison.Ordinal))
return true;

return false;
// for Dotnetdebugger.* messages, treat them as handled, thus not passing them on to the browser
return method.StartsWith("DotnetDebugger.", StringComparison.OrdinalIgnoreCase);
}
private async Task<bool> CallOnFunction(MessageId id, JObject args, CancellationToken token)
{
Expand Down