Standardize test script naming to CLRTestBa{tc,s}hP{re,ost}Commands #76483
Conversation
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAlso converts a few stragglers to the new environment variable format. NOTE: Includes #76458. Don't review until rebased.
|
src/tests/GC/Regressions/Github/Runtime_76219/Runtime_76219.csproj
Outdated
Show resolved
Hide resolved
|
Runtime_76219 looks like #69092 |
markples
changed the title
This seems to have been caused by converting the environment variables to the new format, which means they aren't discarded by CLRTest.Execute.Bash.targets - undoing that change from here. |
|
@trylek PTAL - this includes the naming cleanup that I promised back when you reviewed the disasm checks PR cc @dotnet/jit-contrib - variable rename in tests |
trylek
left a comment
trylek
left a comment
There was a problem hiding this comment.
Looks great, thanks for cleaning this up! I also apologize for not having responded to your last e-mail regarding test merging, I'll make sure to reply before EOD today.
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <CLRTestBashEnvironmentVariable Include="COMPlus_JitFuncInfoLogFile" Value="SIMD.log" /> |
There was a problem hiding this comment.
Why did you revert this from DOTNET_ to COMPlus_?
There was a problem hiding this comment.
Thanks for catching this. I think what happened is (1) I started this change before the COMPlus_ rename, (2) it has been open a long time due to it not being my highest priority and test failures (some real, some not), (3) I missed it when I merged the rename, and (4) my re-checks for envvar, complus_, precommands were limited to *proj and missed this file. I checked again and also found some envvars in the new InstrumentedTiers.csproj (which I have less excuse for since I had already renamed the PreCommands variable in it...)
3 participants
Main change is BashCLRTestPreCommands -> CLRTestBashPreCommands. As part of this I noticed that wasm tests overwrite the Bash precommands, and fixing that breaks them so it isn't touched here. Also, there are several non-Commands variables that start with Ba{tc,s}hTest that aren't touched here.
Remove check on
RunCrossGen2in disasm checks as that is intended as a shell environment variable, not an msbuild variable.Convert a few more tests to the new environment variable format.