[release/7.0] Try enabling regions for native AOT. #75599
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #69108 to release/7.0 /cc @MichalStrehovsky @PeterSolMS Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
Member
|
There's one segfault in https://github.com/dotnet/runtime/pull/69108/checks?check_run_id=8347611410 that would need to be investigated. I'm done for the day. Marking no merge. Still interested in test run results. |
MichalStrehovsky
added
the
NO-MERGE
Member
|
GC is asserting. We don't have all the necessary fixes here. Unclear which one(s) are missing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #69108 to release/7.0
/cc @MichalStrehovsky @PeterSolMS
Customer Impact
(This is quite pushing the RC2 bar at this point, but I want to at least try because shipping with GC configuration that is very different is not great either.)
We couldn't previously enable regions due to crashes. We've since fixed multiple stress issues in NativeAOT and the crashes are now all gone.
This PR allows us to use the GC in the same configuration that CoreCLR uses.
Testing
Passes all our NativeAOT testing.
Risk
There definitely is some.