Skip to content

Assert fat pointers aligned to MinimumFunctionAlignment #75574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichalStrehovsky merged 1 commit into from
Sep 14, 2022
Merged

Assert fat pointers aligned to MinimumFunctionAlignment #75574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...reclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/FatFunctionPointerNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false)
{
var builder = new ObjectDataBuilder(factory, relocsOnly);

// These need to be aligned the same as method pointers because they show up in same contexts
// These need to be aligned the same as method bodies because they show up in same contexts
// (macOS ARM64 has even stricter alignment requirement for the linker, so round up to pointer size)
Debug.Assert(factory.Target.MinimumFunctionAlignment <= factory.Target.PointerSize);
builder.RequireInitialAlignment(factory.Target.PointerSize);

builder.AddSymbol(this);
Expand Down