Skip to content

[ARM64] - IsValidCompareChain should return false if both operands are not integral types #74853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 4 commits into from
Sep 2, 2022
Merged

[ARM64] - IsValidCompareChain should return false if both operands are not integral types #74853

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f747a10
IsValidCompareChain should return 'false' if both operands are not in…
TIHan Aug 31, 2022
42d844e
Add integral type checks in ContainCheckCompareChain
TIHan Aug 31, 2022
9eaa8a1
Check if op is CMP or AND
TIHan Aug 31, 2022
a4aa7cb
feedback
TIHan Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coreclr/jit/lowerarmarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2086,7 +2086,8 @@ bool Lowering::IsValidCompareChain(GenTree* child, GenTree* parent)
return IsValidCompareChain(child->AsOp()->gtGetOp2(), child) &&
IsValidCompareChain(child->AsOp()->gtGetOp1(), child);
}
else if (child->OperIsCmpCompare())
else if (child->OperIsCmpCompare() && varTypeIsIntegral(child->gtGetOp1()) &&
varTypeIsIntegral(child->gtGetOp2()))
{
// Can the child compare be contained.
return IsSafeToContainMem(parent, child);
Expand Down Expand Up @@ -2121,7 +2122,8 @@ bool Lowering::ContainCheckCompareChain(GenTree* child, GenTree* parent, GenTree
return true;
}
// Can the child be contained.
else if (IsSafeToContainMem(parent, child))
else if (IsSafeToContainMem(parent, child) && (child->OperIs(GT_AND) || child->OperIsCmpCompare()) &&
varTypeIsIntegral(child->gtGetOp1()) && varTypeIsIntegral(child->gtGetOp2()))
{
if (child->OperIs(GT_AND))
{
Expand Down