Don't re-use XmlSchemaSet - it's not threadsafe. #74524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mconnew
reviewed
Aug 25, 2022
| internal static XmlSchemaSet PositiveSchemas = SchemaUtils.ReadStringsIntoSchemaSet( | ||
| new string[] { | ||
| private static string[] _positiveSchemas = new string[] { | ||
| @"<?xml version='1.0' encoding='utf-8'?><schema elementFormDefault='qualified' targetNamespace='http://schemas.datacontract.org/2004/07/fooNs' xmlns:tns='http://schemas.datacontract.org/2004/07/fooNs' xmlns:ser='http://schemas.microsoft.com/2003/10/Serialization/' xmlns='http://www.w3.org/2001/XMLSchema'> |
Member
There was a problem hiding this comment.
Nit: naming. Statics should start with s_. Other than that, LGTM
mconnew
approved these changes
Aug 25, 2022
Member
|
FYI: This PR is against main, so in 8.0. To get the bug fixed in 7.0, there will need to be backport. It should not affect milestone of this specific PR. |
Member
Author
|
@karelz - which 7.0 branch(es) do you need this backported to? |
Member
|
/backport to release/7.0 |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2925595397 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74370
These new tests use a few simple collections of schemas grouped in XmlSchemaSet. They were ported from NetFx, where apparently the test environment ran each test one at a time. (Seems that is also the case "on my machine" and in whatever pipelines were run to allow the tests to get checked in.) But XmlSchemaSet is not thread safe, so parallel execution of tests using a static XmlSchemaSet could be problematic. This change builds a new XmlSchemaSet per test instead of re-using a single instance.