Skip to content

[Mono] Only enable Arm intrinsics for full aot mode #74301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamMonoRT merged 2 commits into from
Aug 23, 2022
Merged

[Mono] Only enable Arm intrinsics for full aot mode #74301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e63c5a
Only enable Arm intrinsics for full aot
fanyang-mono Aug 20, 2022
708d72d
Make sure AOT doesn't fall back to interpreter
fanyang-mono Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,14 @@ emit_hardware_intrinsics (
if (!info)
goto support_probe_complete;
id = info->id;

#ifdef TARGET_ARM64
if (!(cfg->compile_aot && cfg->full_aot)) {
Copy link
Member

@lambdageek lambdageek Aug 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs to check cfg->interp:

Suggested change
if (!(cfg->compile_aot && cfg->full_aot)) {
if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp)) {

Also, not sure if we should enable this for llvmonly, too. @vargaz what do you think?

goto support_probe_complete;
}

#endif

// Hardware intrinsics are LLVM-only.
if (!COMPILE_LLVM (cfg) && !intrin_group->jit_supported)
goto support_probe_complete;
Expand Down Expand Up @@ -986,7 +994,7 @@ is_element_type_primitive (MonoType *vector_type)

static MonoInst*
emit_sri_vector (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignature *fsig, MonoInst **args)
{
{
if (!COMPILE_LLVM (cfg))
return NULL;

Expand Down