Skip to content

Skip mode check on Android tests when extracting tar files #74183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlossanlop wants to merge 1 commit into from
Closed

Skip mode check on Android tests when extracting tar files #74183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Formats.Tar/tests/TarTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,8 @@ protected static void AssertEntryModeFromFileSystemEquals(TarEntry entry, UnixFi

protected static void AssertFileModeEquals(string path, UnixFileMode mode)
{
if (!PlatformDetection.IsWindows)
if (!PlatformDetection.IsWindows &&
!PlatformDetection.IsAndroid) // Android may change the requested permissions.)
Copy link
Member

@eerhardt eerhardt Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any docs/links/etc or more information on exactly what/why Android is changing the requested permissions?

{
Assert.Equal(mode, File.GetUnixFileMode(path));
}
Expand Down