Remove 1024 character limit on ODBC connection strings #73149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @roji, @ajcvickers |
ajcvickers
approved these changes
Aug 1, 2022
stephentoub
reviewed
Aug 1, 2022
| { | ||
| // do not check string length if it was expanded because the final result may be shorter than the original | ||
| if ((null != connectionString) && (ODBC32.MAX_CONNECTION_STRING_LENGTH < connectionString.Length)) | ||
| { // MDAC 83536 |
Member
There was a problem hiding this comment.
Do we even know what this was? :)
Member
Author
There was a problem hiding this comment.
We tried finding out - for months (I can send you some email threads if you're really interested). One theory @GrabYourPitchforks had (based on other modifications in the changeset) was that this was a localization thing, i.e. that the P/Invoke call failed for long connection strings with some cryptic/non-localized error message, and that this check was added to surface a better error message. But we didn't manage to find a definitive answer.
stephentoub
approved these changes
Aug 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63630