Don't exclude .gz files from assets.zip #73077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would love to know why .gz specifically is excluded, before this gets merged. Closes: dotnet#36845
|
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsWould love to know why .gz specifically is excluded, before this gets merged. The entire GZipTestData folder was empty (thus excluded) on Android Closes: #36845
|
Member
Contributor
Author
|
Let's ask @EgorBo. I'm sure he remembers changes from 2 years ago 🙃 |
Member
|
heh, I think |
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
Jul 29, 2022
Member
steveisok
left a comment
steveisok
left a comment
There was a problem hiding this comment.
Let's see where we stand after a CI run
This was referenced Jul 29, 2022
akoeplinger
approved these changes
Jul 31, 2022
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM, CI failures are unrelated
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love to know why .gz specifically is excluded, before this gets merged.
The entire GZipTestData folder was empty (thus excluded) on Android
Closes: #36845