Don't hardcode /tmp in named pipe tests, it's not for us on Android #73067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io |
akoeplinger
approved these changes
Jul 29, 2022
Member
akoeplinger
left a comment
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM. It seems we hit cases years ago where TMPDIR on macOS was very long so the named pipe failed, if that's the case then I'd just special case this for Android.
Contributor
Author
|
The OSX tests have passed. Is there some test beyond what's in the libs tests for this TMPDIR issue? |
filipnavara
approved these changes
Jul 29, 2022
Member
|
Is this other one not an issue for Android? |
Contributor
Author
Nope. |
stephentoub
approved these changes
Aug 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #49873